don't coerce texttemplate when no text - fix for scatterternary

etpinard · etpinard · commit c7dd845dba02 · 2019-08-28T16:39:11.000-04:00
diff --git a/src/traces/scatterternary/defaults.js b/src/traces/scatterternary/defaults.js
@@ -58,7 +58,6 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
     coerce('sum');
 
     coerce('text');
-    coerce('texttemplate');
     coerce('hovertext');
     if(traceOut.hoveron !== 'fills') coerce('hovertemplate');
 
@@ -76,6 +75,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
     }
 
     if(subTypes.hasText(traceOut)) {
+        coerce('texttemplate');
         handleTextDefaults(traceIn, traceOut, layout, coerce);
     }
 
diff --git a/test/jasmine/tests/scatterternary_test.js b/test/jasmine/tests/scatterternary_test.js
@@ -556,7 +556,7 @@ describe('Test scatterternary *cliponaxis*', function() {
     });
 });
 
-describe('Test scattergeo texttemplate:', function() {
+describe('Test scatterternary texttemplate:', function() {
     checkTextTemplate([{
         'type': 'scatterternary',
         'a': [3, 2, 5],

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,6 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout`
`58`	`58`	`coerce('sum');`
`59`	`59`
`60`	`60`	`coerce('text');`
`61`		`- coerce('texttemplate');`
`62`	`61`	`coerce('hovertext');`
`63`	`62`	`if(traceOut.hoveron !== 'fills') coerce('hovertemplate');`
`64`	`63`
`@@ -76,6 +75,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout`
`76`	`75`	`}`
`77`	`76`
`78`	`77`	`if(subTypes.hasText(traceOut)) {`
	`78`	`+ coerce('texttemplate');`
`79`	`79`	`handleTextDefaults(traceIn, traceOut, layout, coerce);`
`80`	`80`	`}`
`81`	`81`