Merge pull request #5293 from plotly/fix5289-gcc

Set false locale
plotly · Nov 19, 2020 · aa6f442 · aa6f442
2 parents 4afc441 + 0a21710
commit aa6f442
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/plots/plots.js b/src/plots/plots.js
@@ -667,7 +667,7 @@ function emptySubplotLists() {
  */
 function getFormatObj(gd, formatKeys) {
     var locale = gd._context.locale;
-    if(!locale) locale === 'en-US';
+    if(!locale) locale = 'en-US';
 
     var formatDone = false;
     var formatObj = {};

diff --git a/src/traces/histogram/cross_trace_defaults.js b/src/traces/histogram/cross_trace_defaults.js
@@ -174,10 +174,9 @@ module.exports = function crossTraceDefaults(fullData, fullLayout) {
         }
 
         var binGroupFound = false;
-        for(i = 0; i < traces.length; i++) {
-            traceOut = traces[i];
+        if(traces.length) {
+            traceOut = traces[0];
             binGroupFound = coerce('bingroup');
-            break;
         }
 
         groupName = binGroupFound || groupName;