Skip to content

Commit 8cf665a

Browse files
committed
Merge remote-tracking branch 'origin-plotly/master' into shape_shift
2 parents b00d4d8 + 7d02d9c commit 8cf665a

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+1914
-237
lines changed

draftlogs/7006_add.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- Add property `ticklabelstandoff` and `ticklabelshift` to cartesian axes to adjust positioning of tick labels, with thanks to @my-tien for the contribution! [[#7006](https://github.com/plotly/plotly.js/pull/7006)]

draftlogs/7032_fix.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
- Handle `zorder` between overlayed cartesian subplots [[#7032](https://github.com/plotly/plotly.js/pull/7032)],
2+
This feature was anonymously sponsored: thank you to our sponsor!

draftlogs/7036_add.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- Add axis property `ticklabelindex` for drawing the label for each minor tick n positions away from a major tick, with thanks to @my-tien for the contribution! [[#7036](https://github.com/plotly/plotly.js/pull/7036)]

package-lock.json

Lines changed: 67 additions & 63 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/components/colorbar/defaults.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,8 @@ module.exports = function colorbarDefaults(containerIn, containerOut, layout) {
111111
var font = layout.font;
112112
var opts = {
113113
noAutotickangles: true,
114+
noTicklabelshift: true,
115+
noTicklabelstandoff: true,
114116
outerTicks: false,
115117
font: font
116118
};

src/components/fx/hover.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ var Drawing = require('../drawing');
1515
var Color = require('../color');
1616
var dragElement = require('../dragelement');
1717
var Axes = require('../../plots/cartesian/axes');
18+
var zindexSeparator = require('../../plots/cartesian/constants').zindexSeparator;
1819
var Registry = require('../../registry');
1920

2021
var helpers = require('./helpers');
@@ -261,6 +262,11 @@ exports.loneHover = function loneHover(hoverItems, opts) {
261262
function _hover(gd, evt, subplot, noHoverEvent, eventTarget) {
262263
if(!subplot) subplot = 'xy';
263264

265+
if(typeof subplot === 'string') {
266+
// drop zindex from subplot id
267+
subplot = subplot.split(zindexSeparator)[0];
268+
}
269+
264270
// if the user passed in an array of subplots,
265271
// use those instead of finding overlayed plots
266272
var subplots = Array.isArray(subplot) ? subplot : [subplot];

src/constants/numerical.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ module.exports = {
3737
ONEHOUR: 3600000,
3838
ONEMIN: 60000,
3939
ONESEC: 1000,
40-
40+
ONEMILLI: 1,
41+
ONEMICROSEC: 0.001,
4142
/*
4243
* For fast conversion btwn world calendars and epoch ms, the Julian Day Number
4344
* of the unix epoch. From calendars.instance().newDate(1970, 1, 1).toJD()

src/plot_api/subroutines.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ var SVG_TEXT_ANCHOR_START = 'start';
2424
var SVG_TEXT_ANCHOR_MIDDLE = 'middle';
2525
var SVG_TEXT_ANCHOR_END = 'end';
2626

27+
var zindexSeparator = require('../plots/cartesian/constants').zindexSeparator;
28+
2729
exports.layoutStyles = function(gd) {
2830
return Lib.syncOrAsync([Plots.doAutoMargin, lsInner], gd);
2931
};
@@ -135,7 +137,7 @@ function lsInner(gd) {
135137
var yDomain = plotinfo.yaxis.domain;
136138
var plotgroup = plotinfo.plotgroup;
137139

138-
if(overlappingDomain(xDomain, yDomain, lowerDomains)) {
140+
if(overlappingDomain(xDomain, yDomain, lowerDomains) && subplot.indexOf(zindexSeparator) === -1) {
139141
var pgNode = plotgroup.node();
140142
var plotgroupBg = plotinfo.bg = Lib.ensureSingle(plotgroup, 'rect', 'bg');
141143
pgNode.insertBefore(plotgroupBg.node(), pgNode.childNodes[0]);

0 commit comments

Comments
 (0)