Skip to content

Commit

Permalink
Merge pull request #7095 from birkskyum/remove-node-12-test
Browse files Browse the repository at this point in the history
Remove node 12 ci build-test
  • Loading branch information
archmoj authored Aug 13, 2024
2 parents a8769be + d882d9b commit 22e74b2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 18 deletions.
18 changes: 0 additions & 18 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,22 +10,6 @@ orbs:
# https://hub.docker.com/r/cimg/node/tags/

jobs:
install-and-cibuild-node12: # cibuild using node 12 & npm 6
docker:
- image: cimg/node:12.22.7
working_directory: ~/plotly.js
steps:
- checkout
- run:
name: Set up build environment
command: .circleci/env_build.sh
- run:
name: Pretest
command: npm run pretest
- run:
name: CI-Build
command: npm run cibuild

install-and-cibuild:
docker:
- image: cimg/node:18.20.4
Expand Down Expand Up @@ -478,8 +462,6 @@ workflows:
version: 2
build-and-test:
jobs:
- install-and-cibuild-node12

- install-and-cibuild
- timezone-jasmine:
requires:
Expand Down
2 changes: 2 additions & 0 deletions draftlogs/7095_change.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Drop obsolete `npm v6` installation [[#7095](https://github.com/plotly/plotly.js/pull/7095)]

0 comments on commit 22e74b2

Please sign in to comment.