waterfall hover bug fix

archmoj · archmoj · commit 1c82f91f4399 · 2019-05-01T14:17:44.000-04:00
diff --git a/src/traces/waterfall/hover.js b/src/traces/waterfall/hover.js
@@ -35,8 +35,6 @@ module.exports = function hoverPoints(pointData, xval, yval, hovermode) {
     var index = point.index;
     var di = cd[index];
 
-    var sizeLetter = isHorizontal ? 'x' : 'y';
-
     var size = (di.isSum) ? di.b + di.s : di.rawS;
 
     if(!di.isSum) {
@@ -50,8 +48,6 @@ module.exports = function hoverPoints(pointData, xval, yval, hovermode) {
         }
         // display initial value
         point.extraText += '<br>Initial: ' + formatNumber(di.b + di.s - size);
-    } else {
-        point[sizeLetter + 'LabelVal'] = formatNumber(size);
     }
 
     point.color = getTraceColor(trace, di);

Original file line number	Diff line number	Diff line change
`@@ -35,8 +35,6 @@ module.exports = function hoverPoints(pointData, xval, yval, hovermode) {`
`35`	`35`	`var index = point.index;`
`36`	`36`	`var di = cd[index];`
`37`	`37`
`38`		`- var sizeLetter = isHorizontal ? 'x' : 'y';`
`39`		`-`
`40`	`38`	`var size = (di.isSum) ? di.b + di.s : di.rawS;`
`41`	`39`
`42`	`40`	`if(!di.isSum) {`
`@@ -50,8 +48,6 @@ module.exports = function hoverPoints(pointData, xval, yval, hovermode) {`
`50`	`48`	`}`
`51`	`49`	`// display initial value`
`52`	`50`	`point.extraText += '<br>Initial: ' + formatNumber(di.b + di.s - size);`
`53`		`- } else {`
`54`		`- point[sizeLetter + 'LabelVal'] = formatNumber(size);`
`55`	`51`	`}`
`56`	`52`
`57`	`53`	`point.color = getTraceColor(trace, di);`