Skip to content

Extensively Updated Docstring for Proptypes #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 18, 2019
Merged

Extensively Updated Docstring for Proptypes #26

merged 4 commits into from
Jan 18, 2019

Conversation

xhluca
Copy link

@xhluca xhluca commented Jan 13, 2019

Added references to Cytoscape.js docs, as well as a description of all items for the element and style dictionaries in bullet points. Gave an overview of items for tapNode and tapEdge dictionaries.

Please only check this file for review: https://github.com/plotly/dash-cytoscape/pull/26/files#diff-f03ef14fc795548335a0c93e91747b4e

Added references to Cytoscape.js docs, as well as a description of all
items for the element and style dictionaries in bullet points. Gave an
overview of items for tapNode and tapEdge dictionaries
@xhluca xhluca requested a review from chriddyp January 13, 2019 23:05
@xhluca
Copy link
Author

xhluca commented Jan 18, 2019

@chriddyp I think this PR good. Is it ok to merge this, that way I can work on updating the webpack and python builder so it's up to date with the boilerplate?

@chriddyp
Copy link
Member

💃

@xhluca xhluca merged commit 99bcc47 into master Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants