Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply eslint, prettier, and black #193

Merged
merged 60 commits into from
Sep 27, 2023
Merged

Apply eslint, prettier, and black #193

merged 60 commits into from
Sep 27, 2023

Conversation

Farkites
Copy link
Contributor

@Farkites Farkites commented Aug 14, 2023 •
edited
Loading

About

Applied format and lint tools

Description of changes

Added

  • prettier and black lint/format scripts have been added.
  • React 18 job has been added to circleCI workflow.

Changed

  • Dash has been upgraded to 2.* in requirements.txt and tests/requirements.txt.
  • Dependencies have been upgraded to lastest versions.
  • CircleCI workflow has been updated to version 2.1.
  • Python version in CircleCI workflow has been updated to 3.11.
  • Node version in CircleCI workflow has been updated to 20.5.1.

Fixed

  • CircleCI workflow has been fixed.

Pre-Merge checklist

  • The project was correctly built with npm run build:all.
  • If there was any conflict, it was solved correctly.
  • All changes were documented in CHANGELOG.md.
  • All tests on CircleCI have passed.
  • All Percy visual changes have been approved.
  • Two people have 💃'd the pull request. You can be one of these people if you are a Dash Cytoscape core contributor.

@Farkites Farkites requested a review from alexcjohnson as a code owner August 14, 2023 11:14
alexcjohnson
alexcjohnson reviewed Aug 15, 2023
View reviewed changes
Farkites added 20 commits August 16, 2023 10:07
alexcjohnson
alexcjohnson reviewed Sep 19, 2023
View reviewed changes
alexcjohnson
alexcjohnson reviewed Sep 19, 2023
View reviewed changes
alexcjohnson
alexcjohnson reviewed Sep 19, 2023
View reviewed changes
alexcjohnson
alexcjohnson approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Great work!

@emilykl
Copy link
Contributor

emilykl commented Sep 27, 2023

🥳 🥳 🥳

This rocks! Great work @Farkites !

@Farkites Farkites merged commit 13cb7ff into plotly:master Sep 27, 2023
This was referenced Jan 26, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Farkites @emilykl @alexcjohnson