Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Leaflet mapping and context menu #157

Closed
wants to merge 47 commits into from
Closed

Feature: Leaflet mapping and context menu #157

wants to merge 47 commits into from

Conversation

mtwichan
Copy link

@mtwichan mtwichan commented Oct 3, 2021 •
edited
Loading

About

This is a new feature for Dash-cytoscape which includes integration with Leaflet.js and a context menu feature.

Description of changes

Users can render their cytoscape graphs on Leaflet map using any tile server supported by Leaflet. This, also allows users to graph Cytoscape nodes using latitude and longitude coordinates. Additionally, they can create context menus that appear on right-click, with or without the Leaflet map.

The context menu is fully customizable. Developers have full control of what options are shown in the context menu and the business logic associated with clicking on that context menu selection.

cytoscape-leaflet-dash

Pre-Merge checklist

  • The project was correctly built with npm run build:all.
  • If there was any conflict, it was solved correctly.
  • All changes were documented in CHANGELOG.md.
  • All tests on CircleCI have passed.
  • All Percy visual changes have been approved.
  • Two people have 💃'd the pull request. You can be one of these people if you are a Dash Cytoscape core contributor.

Reference Issues

Leaflet feature: zyphr-solutions#2
Context menu feature: zyphr-solutions#1

Other comments

This feature was created in collaboration with @plotly and reviewed by @alexcjohnson

Manfred Cheung and others added 30 commits August 15, 2021 16:13
Fix backends build error
2c16c1f
Add bilkent context menu feature
2151388
Build
759e9c4
Address Alex PR feedback
9cb9116
@alexcjohnson
Update src/lib/components/Cytoscape.react.js
2adf7ad 
Co-authored-by: Alex Johnson <alex@plot.ly>
Rename cxtmenu to contextmenu
7ced7be
@maxkfranz
Merge pull request #1 from mj3cheun/bilkent-cxtmenu
adfbddc 
Add Bilkent Cxtmenu
Add leaflet feature
6f103b0
Build
1cb171f
Change default lat/long node properties and add option to customize them
5aae100
Build
185b3c9
@maxkfranz
Update to cytoscape-leaf@1.2.1
76b1bcf
@maxkfranz
Add support for leaflet.preset and handle default tiles better
bfa5d07
@maxkfranz
Update leaflet demo
f6f7c5d 
- Enable box selection
- Remove autounselectify
- Show preset example
@maxkfranz
Build
68edf9b
Fix documentation error
c4ee3c6
Update example to demonstrate label name source and boxSelectionEnabled
d750e4b
Poll cytoscape container and overlay the map on top of the cytoscape …
984a8e1 
…container
Remove unused import from example
a1cceb6
Add latitudeId and longitudeId properties to leaflet
70321cc
Build
1c066e9
Fix broken initialization
66595b5
Build
984e613
Add zoomOffset and tileSize properties to leaflet
624906c
Build
0862d82
Respond to PR comments
c5be394
Build
1eed924
@mtwichan
Merge pull request #2 from mj3cheun/map
7d807d2 
Add leaflet
@kinimesi
Revert "Fix backends build error"
d43837a 
This reverts commit 2c16c1f.
@kinimesi
Merge branch 'master' of https://github.com/plotly/dash-cytoscape int…
3a3f4da 
…o plotly-master
@mtwichan
Copy link
Author

mtwichan commented Dec 8, 2021 •
edited
Loading

Waiting on @kinimesi to complete the following before we can merge the PR:

The order of execution of tasks should be the following:

  1. Solve: Update cycle broken after callback #159
  2. Test new Dash Cytoscape features and write tests for the features
  3. Add any new features and bug fixes to Dash Cytoscape CHANGELOG and any other relevant Dash Cytoscape release/versioning files. The new version will be 0.4.0
  4. Merge 🎉
  5. Write documentation for new Dash Cytoscape features (contextMenu & leaflet)
  6. Ping when finished so I can write a release statement for the Plotly forums and newsletter, and so that Plotly can push to PyPi

CC: @alexcjohnson @Kully @jackparmer

@Farkites
Copy link
Contributor

Closing this PR in favour of #200 and #196

@Farkites Farkites closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson Awaiting requested review from alexcjohnson alexcjohnson is a code owner

@xhluca xhluca Awaiting requested review from xhluca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mtwichan @Farkites @maxkfranz @kinimesi