Skip to content

Feature: Leaflet mapping and context menu - #157

Closed
mtwichan wants to merge 47 commits into
plotly:masterfrom
zyphr-solutions:master
Closed

mtwichan wants to merge 47 commits into
plotly:masterfrom
zyphr-solutions:master

Conversation

@mtwichan

@mtwichan mtwichan commented Oct 3, 2021

Copy link
Copy Markdown

About

This is a new feature for Dash-cytoscape which includes integration with Leaflet.js and a context menu feature.

Description of changes

Users can render their cytoscape graphs on Leaflet map using any tile server supported by Leaflet. This, also allows users to graph Cytoscape nodes using latitude and longitude coordinates. Additionally, they can create context menus that appear on right-click, with or without the Leaflet map.

The context menu is fully customizable. Developers have full control of what options are shown in the context menu and the business logic associated with clicking on that context menu selection.

cytoscape-leaflet-dash

Pre-Merge checklist

  • The project was correctly built with npm run build:all.
  • If there was any conflict, it was solved correctly.
  • All changes were documented in CHANGELOG.md.
  • All tests on CircleCI have passed.
  • All Percy visual changes have been approved.
  • Two people have 💃'd the pull request. You can be one of these people if you are a Dash Cytoscape core contributor.

Reference Issues

Leaflet feature: zyphr-solutions#2
Context menu feature: zyphr-solutions#1

Other comments

This feature was created in collaboration with @plotly and reviewed by @alexcjohnson

Manfred Cheung and others added 30 commits August 15, 2021 16:13
Co-authored-by: Alex Johnson <alex@plot.ly>
- Enable box selection
- Remove autounselectify
- Show preset example
@mtwichan

mtwichan commented Dec 8, 2021

Copy link
Copy Markdown
Author

Waiting on @kinimesi to complete the following before we can merge the PR:

The order of execution of tasks should be the following:

  1. Solve: Update cycle broken after callback #159
  2. Test new Dash Cytoscape features and write tests for the features
  3. Add any new features and bug fixes to Dash Cytoscape CHANGELOG and any other relevant Dash Cytoscape release/versioning files. The new version will be 0.4.0
  4. Merge 🎉
  5. Write documentation for new Dash Cytoscape features (contextMenu & leaflet)
  6. Ping when finished so I can write a release statement for the Plotly forums and newsletter, and so that Plotly can push to PyPi

CC: @alexcjohnson @Kully @jackparmer

@Farkites

Copy link
Copy Markdown
Contributor

Closing this PR in favour of #200 and #196

@Farkites Farkites closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants