fix: use /usr/bin/env to find bash#203
Merged
ayjayt merged 1 commit intoandrew/mac-buildfrom Jul 30, 2024
Merged
Conversation
Default bash on MacOS is 3.*, but these scripts need 5.*, so this PR changes the `#!` line in these shell scripts to use `/usr/bin/env bash` to find and run bash instead of using `/bin/bash`, which allows users to install a more recent version of bash and have it picked up.
Collaborator
Author
|
same PR @gvwilson just onto the dev branch not onto master, otherwise we pull in all the commits |
Collaborator
Author
|
its fine, its done |
Contributor
|
thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default bash on MacOS is 3., but these scripts need 5., so this PR changes the
#!line in these shell scripts to use/usr/bin/env bashto find and run bash instead of using/bin/bash, which allows users to install a more recent version of bash and have it picked up.from @gvwilson , here we're not merging into master