[Python] Display error stream when interrupting the program#160
Merged
alexcjohnson merged 1 commit intoplotly:masterfrom Mar 9, 2023
Lucas-C:display-error-stream-on-interrupt
Merged
[Python] Display error stream when interrupting the program#160alexcjohnson merged 1 commit intoplotly:masterfrom Lucas-C:display-error-stream-on-interrupt
alexcjohnson merged 1 commit intoplotly:masterfrom
Lucas-C:display-error-stream-on-interrupt
Conversation
alexcjohnson
approved these changes
Mar 9, 2023
alexcjohnson
left a comment
There was a problem hiding this comment.
💃 Thanks @Lucas-C, this definitely looks useful!
I'll merge this now, but it may be some time before we can make a new release including it - we need to investigate #149 and the other open PRs related to hanging processes, and as you've discovered building Kaleido is a tricky process, as is testing it on all the platforms it compiles for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I am currently facing a case of Kaleido hanging forever, from Python code calling
plotly.graph_objects.Figure.to_image(format="png", engine="kaleido").I hope that this PR may be the solution I need: #149
In the meantime, adding those 3 lines allowed me access to the
executable/bin/kaleidostderr when interrupting the whole program using CTRL+C:For this reason, it seems to me a useful an innocuous patch.