Remove all traces of Products.CMFQuickInstaller #1267
Conversation
|
@jensens thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
jensens
force-pushed
the
fix-missing-quickinstaller
branch
from
6ed4add to
84c05dd
Compare
|
@jenkins-plone-org please run jobs |
| @@ -2,16 +2,22 @@ | |||
| from Products.CMFCore.utils import getToolByName | |||
| from Products.CMFPlone import PloneMessageFactory as _ | |||
| from Products.CMFPlone.interfaces import INonInstallable | |||
| from Products.CMFQuickInstallerTool.interfaces import ( | |||
There was a problem hiding this comment.
Uhm, this is strange, the iface was moved to:
from Products.CMFPlone.interfaces import INonInstallable
And we should have aliases for that:
Don't you have plone.app.upgrade?
I think the proper fix is to replace the import given that the alias is there since 5.1:
https://github.com/plone/Products.CMFPlone/blob/5.1.x/Products/CMFPlone/interfaces/__init__.py#L38
and this package supports Plone 5.2 only.
Also the towncrier entry should be updated accordingly
There was a problem hiding this comment.
No I do only depend on Products.CMFPlone. Which is totally fine. plone.app.upgrade in only installed in a single service instance. The cluster runs usually without.
There was a problem hiding this comment.
I think the proper fix is to replace the import given that the alias is there since 5.1
Right, this the current master does not support 5.1 anyway. Removal is probably the best.
jensens
force-pushed
the
fix-missing-quickinstaller
branch
from
84c05dd to
afc2301
Compare
jensens
changed the title
jensens
force-pushed
the
fix-missing-quickinstaller
branch
from
afc2301 to
6900c94
Compare
|
@jenkins-plone-org please run jobs |
For some reason I got an
Products.CMFQuickInstallerimport error in Plone 6. Maybe because its gone? Question is why it worked in past? Did it?Anyway, this fixes the problem.