Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin github.com/pion/dtls/v2 version using the replace directive #534

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

Danielius1922
Copy link
Member

No description provided.

@Danielius1922 Danielius1922 linked an issue Feb 14, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (51f2671) 74.11% compared to head (d0eb19d) 73.08%.

❗ Current head d0eb19d differs from pull request most recent head 1a328d7. Consider uploading reports for the commit 1a328d7 to get more accurate results

Files Patch % Lines
tcp/server/server.go 0.00% 0 Missing and 2 partials ⚠️
dtls/client.go 0.00% 0 Missing and 1 partial ⚠️
dtls/server/server.go 0.00% 0 Missing and 1 partial ⚠️
net/connUDP.go 0.00% 1 Missing ⚠️
tcp/client.go 0.00% 0 Missing and 1 partial ⚠️
tcp/client/conn.go 66.66% 0 Missing and 1 partial ⚠️
udp/client.go 0.00% 0 Missing and 1 partial ⚠️
udp/client/conn.go 80.00% 0 Missing and 1 partial ⚠️
udp/server/server.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
- Coverage   74.11%   73.08%   -1.03%     
==========================================
  Files          71       72       +1     
  Lines        5853     5945      +92     
==========================================
+ Hits         4338     4345       +7     
- Misses       1122     1209      +87     
+ Partials      393      391       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.8% Duplication on New Code (required ≤ 5%)

See analysis details on SonarCloud

@Danielius1922 Danielius1922 merged commit fa8846c into master Feb 15, 2024
11 of 12 checks passed
@Danielius1922 Danielius1922 deleted the adam/feature/fix-build branch February 15, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pion pkg/net dependency error
3 participants