Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable inactivity monitor for DTLS/UDP by default #312

Closed
Tracked by #368
jkralik opened this issue Mar 16, 2022 · 1 comment
Closed
Tracked by #368

Enable inactivity monitor for DTLS/UDP by default #312

jkralik opened this issue Mar 16, 2022 · 1 comment

Comments

@jkralik
Copy link
Member

jkralik commented Mar 16, 2022

I'm not using DTLS.

Ah, I think the confusing part is the defaults. The example code and the main README.md produces code that effectively leaks connections? Is this ever desired? In long-running scenarios or under load clients will invariably connect and re-connect (especially IoT's with flaky connection, watchdogs etc.), and this adds up over time.

Seems it's not limited to DTLS:

go-coap/udp/server.go

Lines 58 to 60 in 073d2c2

createInactivityMonitor: func() inactivity.Monitor {
return inactivity.NewNilMonitor()
},

Perhaps the default should be set to something or be clarified in the README?

Originally posted by @JosefWN in #311 (comment)

@jkralik jkralik mentioned this issue Jul 30, 2022
12 tasks
@jkralik
Copy link
Member Author

jkralik commented Oct 15, 2022

Used as default for v3. Fill free to reopen it.

@jkralik jkralik closed this as completed Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant