Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect NSTART handling #226

Closed
Tracked by #368
kegsay opened this issue May 11, 2021 · 1 comment
Closed
Tracked by #368

Incorrect NSTART handling #226

kegsay opened this issue May 11, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@kegsay
Copy link
Contributor

kegsay commented May 11, 2021

I've been wondering why NSTART is a time.Duration when, as far as I understand, it is the max number of simultaneous outstanding requests to the client/server. Looking at the use of nstart I don't see how this follows the RFC:

   In order not to cause congestion, clients (including proxies) MUST
   strictly limit the number of simultaneous outstanding interactions
   that they maintain to a given server (including proxies) to NSTART.
   An outstanding interaction is either a CON for which an ACK has not
   yet been received but is still expected (message layer) or a request
   for which neither a response nor an Acknowledgment message has yet
   been received but is still expected (which may both occur at the same
   time, counting as one outstanding interaction).  The default value of
   NSTART for this specification is 1.

https://datatracker.ietf.org/doc/html/rfc7252#section-4.7

Am I missing something here? Thanks!

@jkralik jkralik added the bug Something isn't working label May 20, 2021
@jkralik
Copy link
Member

jkralik commented May 20, 2021

Thx for reporting - this a bug.

@jkralik jkralik mentioned this issue Jul 30, 2022
12 tasks
@jkralik jkralik closed this as completed Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants