Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for review: Allow unused categories and tags #5

Open
jimafisk opened this issue Jul 1, 2022 · 0 comments
Open

Changes for review: Allow unused categories and tags #5

jimafisk opened this issue Jul 1, 2022 · 0 comments

Comments

@jimafisk
Copy link
Contributor

jimafisk commented Jul 1, 2022

@roobyz I meant to create a PR for this, but I forgot that I was pushing directly to this repo. I made a couple of changes I want you to be aware of:

  1. I updated .gitignore so we're tracking the themes dir: fe501df. The hope is that you track theme files with your project instead of using a git submodule. Should clear up confusion like I noted here: Deploy failed in build step jamestagal/edtechdesigner#29 (comment)
  2. There was a bug in the theme where if you created a catgs or tags that wasn't used in posts content that it would break the build as discussed in this issue: Deploy failed in build step jamestagal/edtechdesigner#29. In Ben's case, there was a corresponding posts JSON content source in the project with the same name as every original post in the theme, but the theme was still defining catgs and tags in its content source that were no longer being used (since all the posts in the theme were overridden). I pushed a fix that should allow the build to complete, but it might not ultimately be the way you want to handle this: 7dd5f50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant