Support Promise.all for missing-playwright-await (#117)

* Better scope for no-skipped-tests

* Add examples folder for testing

* Better scope for no-useless-not

* max-nested-describe

* missing-playwright-await

* no-focused-test

* no-force-option

* no-page-pause

* no-restricted-matchers

* Update ecma version

* no-wait-for-timeout

* prefer-lowercase-title

* prefer-strict-equal

* prefer-to-be

* prefer-to-have-length

* require-top-level-describe

* valid-expect

* no-conditional-in-test

* Update example eslintrc

* no-eval

* Cleanup

* no-element-handle

* Order

* Use dedent

* Update examples

* Tests

* Support `Promise.all`

Author: mskelton

src/rules/missing-playwright-await.ts

@@ -87,9 +87,22 @@ function getCallType(
   }
 }
 
+function isPromiseAll(node: Rule.Node) {
+  return node.type === 'ArrayExpression' &&
+    node.parent.type === 'CallExpression' &&
+    node.parent.callee.type === 'MemberExpression' &&
+    isIdentifier(node.parent.callee.object, 'Promise') &&
+    isIdentifier(node.parent.callee.property, 'all')
+    ? node.parent
+    : null;
+}
+
 function checkValidity(node: Rule.Node): ESTree.Node | undefined {
-  return validTypes.has(node.parent.type)
-    ? undefined
+  if (validTypes.has(node.parent.type)) return;
+
+  const promiseAll = isPromiseAll(node.parent);
+  return promiseAll
+    ? checkValidity(promiseAll)
     : node.parent.type === 'MemberExpression' ||
       (node.parent.type === 'CallExpression' && node.parent.callee === node)
     ? checkValidity(node.parent)

test/spec/missing-playwright-await.spec.ts

@@ -1,5 +1,6 @@
 import { runRuleTester, test } from '../utils/rule-tester';
 import rule from '../../src/rules/missing-playwright-await';
+import * as dedent from 'dedent';
 
 runRuleTester('missing-playwright-await', rule, {
   valid: [
@@ -32,6 +33,15 @@ runRuleTester('missing-playwright-await', rule, {
     { code: test('await expect[`poll`](() => foo).toBeTruthy()') },
     // test.step
     { code: test("await test.step('foo', async () => {})") },
+    // Promise.all
+    {
+      code: test(`
+        await Promise.all([
+          expect(page.locator("foo")).toHaveText("bar"),
+          expect(page).toHaveTitle("baz"),
+        ])
+      `),
+    },
   ],
   invalid: [
     {
@@ -196,5 +206,27 @@ runRuleTester('missing-playwright-await', rule, {
         },
       ],
     },
+    {
+      code: dedent(
+        test(`
+          const promises = [
+            expect(page.locator("foo")).toHaveText("bar"),
+            expect(page).toHaveTitle("baz"),
+          ]
+        `)
+      ),
+      output: dedent(
+        test(`
+          const promises = [
+            await expect(page.locator("foo")).toHaveText("bar"),
+            await expect(page).toHaveTitle("baz"),
+          ]
+        `)
+      ),
+      errors: [
+        { messageId: 'expect', line: 3, column: 4, endLine: 3, endColumn: 10 },
+        { messageId: 'expect', line: 4, column: 4, endLine: 4, endColumn: 10 },
+      ],
+    },
   ],
 });