Enhancements to aiohttp.web

[playpauseandstop]

There are several desired enhancements to aiohttp.web library that widely used in backend applications which should be added to rororo,

• Improved Application to support debug mode and proper logging while serving with gunicorn
• add_route context manager
• Handling single static files, not directories
• Error handling middleware

[playpauseandstop]

add_route context manager example,

from rororo.aio.routes import add_route_context

from . import api as api_views


app = Application(...)

with add_route_context(app, api_views, '/api', 'api') as add_route:
    add_route('GET', '/', 'index')
    add_route('POST', '/posts', 'add_post')
    add_route('GET', '/posts', 'list_posts')

This should create 3 route handlers,

GET /api/ -> api.index
POST /api/posts -> api.add_post
GET /api/posts -> api.list_posts

[playpauseandstop]

add_static context manager example,

from pathlib import Path

from rororo.aio.routes import add_static_context


rel = Path(__file__).dirname

app = Application(...)

static_dir = rel / '..' / 'static'
with add_static_context(app, static_dir) as add_static:
    add_static('/favicon.ico', 'images/favicon.ico')
    add_static('/static')

This should create 2 static route handlers,

GET /favicon.ico -> ../static/images/favicon.ico
GET /static/{filename} -> ../static/{filename}

[sloria]

Greetings!

I hope you don't mind, but I adapted your add_route_context helper in a utilities package I just published: aiohttp_utils.

I made a few changes to make the following possible:

1. Passing handlers rather than strings to add_route
2. Passing both module names and handler names as strings.

See the examples here: https://aiohttp-utils.readthedocs.org/en/latest/modules/routing.html#aiohttp_utils.routing.add_route_context

I'd be glad to contribute them to rororo if you'd like.

[playpauseandstop]

@sloria

Greetings! Great to hear about aiohttp_utils, closing this ticket in favor of,

• Using add_route_context from aiohttp_utils
• add_static_context is deprecated cause of planned improvements to static handling in aiohttp, Improvements to static routes aio-libs/aiohttp#468 (comment)
• Error handling middleware and other middlewares are subject to rethink