Add Options Object Support to StandardMaterial#constructor
#7820
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns
StandardMaterial#constructor
with other classes likeTexture#constructor
to accept an optional options object, allowing properties (e.g., diffuse, depthTest) to be set during instantiation without being forced to call additional methods likeMaterial#update
- reducing boilerplate code.Example:
Basically, the aim is to keep the code short and readable and to reduce manual bookkeeping.
@mvaligursky I'm not entirely sure about the requirement for
this.update()
or if these property assignments should happen before e.g.this.reset()
?I confirm I have read the contributing guidelines and signed the Contributor License Agreement.