Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requesting a 7.3.2 release #240

Closed
bmish opened this issue Sep 28, 2022 · 6 comments
Closed

Requesting a 7.3.2 release #240

bmish opened this issue Sep 28, 2022 · 6 comments

Comments

@bmish
Copy link
Collaborator

bmish commented Sep 28, 2022

Requesting a patch release with this fix that was merged a month ago:

We should also make sure the github releases are created:

I would also be happy to help maintain this plugin.

@platinumazure
Copy link
Owner

What do you think of switching to conventional commits as well? (You might have brought this up in the past and I know your own commit messages follow that convention.)

I'm coming around to the idea of using that plus release-it and automating all this. I hate to ask, but I would love the help setting it up.

I'll probably make you a maintainer at some point as well.

@bmish
Copy link
Collaborator Author

bmish commented Oct 1, 2022

Yep, supportive of that would be happy to help!

@bmish
Copy link
Collaborator Author

bmish commented Oct 27, 2022

I'll release this once #243 is merged.

@platinumazure
Copy link
Owner

@bmish #243 is merged!

Feel free to cut a patch release anytime. I just do npm version patch, npm publish, git push origin master --tags. (And we know that the GitHub release is manual at this point.)

If you have any issues, find me on Discord. I'm on vacation, so I may be slow to respond.

@bmish
Copy link
Collaborator Author

bmish commented Nov 4, 2022

@bmish bmish closed this as completed Nov 4, 2022
@platinumazure
Copy link
Owner

Thanks @bmish!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants