Fix SAPI shutdown #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so each instance of Embed holds an Arc so that the underlying SAPI may be dropped when there are no more Embeds. A Weak is held to attempt to upgrade an existing SAPI for any future Embed constructions, but will construct a new SAPI any time one is unavailable via the Weak.
Qard
force-pushed
the
fix-shutdown-cleanup
branch
2 times, most recently
from
d6c0172 to
bc53dd3
Compare
Qard
force-pushed
the
fix-shutdown-cleanup
branch
from
bc53dd3 to
1a44725
Compare
simone-sanfratello
approved these changes
May 27, 2025
Qard
added a commit
that referenced
this pull request
May 27, 2025
Qard
added a commit
that referenced
this pull request
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so each instance of Embed holds an Arc so that the underlying SAPI may be dropped when there are no more Embeds. A Weak is held to attempt to upgrade an existing SAPI for any future Embed constructions, but will construct a new SAPI any time one is unavailable via the Weak.