Improve safety and test coverage #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qard
force-pushed
the
safety-and-test-improvements
branch
8 times, most recently
from
1322fab to
e8c8d80
Compare
Qard
force-pushed
the
safety-and-test-improvements
branch
from
e8c8d80 to
a3de659
Compare
ShogunPanda
approved these changes
May 23, 2025
Because the Linux build happens in a docker task, the PHP headers are not available to build ext-php-rs, which is required to do the cargo test.
Qard
force-pushed
the
safety-and-test-improvements
branch
from
4702935 to
0b14d3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates all
unwrap()andexpect()uses, replacing them with proper error propagation, so there should no longer be any possibility of crashing, it should just throw errors into JS where relevant.I've also updated the doc tests to be correct and ensured they are run in CI properly.
Additionally I did some restructuring to split up the code in the php crate a bit so it's not just in one giant file. 😅
It also enables clippy linting, which was disabled for a while as there was a lot of noise from things which needed adjusting.