-
Notifications
You must be signed in to change notification settings - Fork 0
abundance fraction per cluster column #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @Alex-Davydov, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a valuable new data point, the abundance fraction per cluster, to the clustering results, enhancing the analytical output by providing a normalized measure of cluster size. Concurrently, a comprehensive update of various project dependencies was performed to maintain the codebase's health and integrate the latest library versions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new column abundance_fraction_per_cluster to the output, which represents the fraction of total abundance for each cluster. The changes involve updating the python scripts to calculate this new value and to include it in the output files. The logic for the calculation is sound. I've provided one suggestion to make the implementation more idiomatic and efficient using polars expressions, avoiding unnecessary data transfer between the polars engine and Python.
| total_abundance = abundances_per_cluster.select(pl.sum('abundance_per_cluster')).item() | ||
| abundances_per_cluster = abundances_per_cluster.with_columns( | ||
| pl.when(pl.lit(total_abundance) > 0) | ||
| .then(pl.col('abundance_per_cluster') / pl.lit(total_abundance)) | ||
| .otherwise(pl.lit(0.0, dtype=pl.Float64)) | ||
| .alias('abundance_fraction_per_cluster') | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The calculation of abundance_fraction_per_cluster can be made more efficient and idiomatic by performing the entire operation within the polars expression, avoiding the need to extract total_abundance into a Python variable using .item(). This keeps the computation entirely within the polars engine.
You can define the sum as a polars expression and reuse it.
| total_abundance = abundances_per_cluster.select(pl.sum('abundance_per_cluster')).item() | |
| abundances_per_cluster = abundances_per_cluster.with_columns( | |
| pl.when(pl.lit(total_abundance) > 0) | |
| .then(pl.col('abundance_per_cluster') / pl.lit(total_abundance)) | |
| .otherwise(pl.lit(0.0, dtype=pl.Float64)) | |
| .alias('abundance_fraction_per_cluster') | |
| ) | |
| total_abundance_expr = pl.sum('abundance_per_cluster') | |
| abundances_per_cluster = abundances_per_cluster.with_columns( | |
| pl.when(total_abundance_expr > 0) | |
| .then(pl.col('abundance_per_cluster') / total_abundance_expr) | |
| .otherwise(pl.lit(0.0, dtype=pl.Float64)) | |
| .alias('abundance_fraction_per_cluster') | |
| ) |
No description provided.