session stops background loop on exit/close #1146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ischneider
force-pushed
the
session-closes-background-loop
branch
3 times, most recently
from
6efb939 to
52808a3
Compare
ischneider
force-pushed
the
session-closes-background-loop
branch
from
52808a3 to
b06dd43
Compare
ischneider
force-pushed
the
session-closes-background-loop
branch
from
b06dd43 to
7030927
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to cleanly close the event loop and, therefore, the background thread.
One issue is that the sync API doesn't have any explicit resource cleanup hook.
I attempted to override
__del__for theSessionas a means to cleanup and while this "worked" (tests all pass without -Werror)... When run w/ -Werror, it seems like a socket gets garbage collected before close is called and this triggers a warning that fails the test due to -Werror (convert warnings to errors)