Skip to content

oauth via plauth lib for main 3.0 dev branch #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 119 commits into from
May 15, 2025

Conversation

carl-adams-planet
Copy link
Contributor

Change planet.Auth over to using the planet-auth-python library to move towards OAuth2 as the preferred authentication mechanism..

This is the same as PR 1063, but targeting a draft 3.0 branch over the current mainline stable main.

@carl-adams-planet carl-adams-planet changed the title Carl/oauth via plauth lib oauth via plauth lib for main 3.0 dev branch Apr 28, 2025
@ischneider
Copy link
Member

lgtm

logging.basicConfig(level=logging.CRITICAL)


class DemoStorageProvider(ObjectStorageProvider):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is DemoStorageProvider the same across multiple code snippet files? If so does it make sense to define the object once somewhere and reference it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to. I didn't figure out the best way to do that still have the snippets being entirely self contained as they are painted in the readthedocs rendering of the included samples.

Right now it's biased towards examples you can simply smack the "copy to clipboard" button on and run.

Copy link
Contributor

@asonnenschein asonnenschein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carl-adams-planet carl-adams-planet merged commit 356b05e into main-3.0-dev May 15, 2025
9 checks passed
@carl-adams-planet carl-adams-planet deleted the carl/oauth-via-plauth-lib branch May 15, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants