-
Notifications
You must be signed in to change notification settings - Fork 95
oauth via plauth lib for main 3.0 dev branch #1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…net-client-python into carl/oauth-via-plauth-lib
lgtm |
logging.basicConfig(level=logging.CRITICAL) | ||
|
||
|
||
class DemoStorageProvider(ObjectStorageProvider): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is DemoStorageProvider
the same across multiple code snippet files? If so does it make sense to define the object once somewhere and reference it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love to. I didn't figure out the best way to do that still have the snippets being entirely self contained as they are painted in the readthedocs rendering of the included samples.
Right now it's biased towards examples you can simply smack the "copy to clipboard" button on and run.
examples/auth-session-management/app_managed_auth_state__in_memory__oauth_m2m.py
Show resolved
Hide resolved
...ion-management/app_managed_auth_state__in_memory__oauth_user_devicecode__external_browser.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Change planet.Auth over to using the planet-auth-python library to move towards OAuth2 as the preferred authentication mechanism..
This is the same as PR 1063, but targeting a draft 3.0 branch over the current mainline stable main.