Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path_prefix to Subscriptions API request builder #1018

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

pl-gideon
Copy link
Member

Closes #1017

Proposed Changes:

For inclusion in changelog (if applicable):

  1. Add path_prefix to Subscriptions API request builder.

Diff of User Interface

Old behavior:

New behavior:

path_prefix is an optional parameter for google_cloud_storage, amazon_s3, azure_blob_storage, and oracle_cloud_storage in subscriptions_request.

PR Checklist:

  • This PR is as small and focused as possible
  • If this PR includes proposed changes for inclusion in the changelog, the title of this PR summarizes those changes and is ready for inclusion in the Changelog.
  • I have updated docstrings for function changes and docs in the 'docs' folder for user interface / behavior changes
  • This PR does not break any examples or I have updated them

Copy link
Contributor

@asonnenschein asonnenschein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pl-gideon pl-gideon merged commit 6f95df6 into main Dec 13, 2023
10 checks passed
@adamweiner adamweiner mentioned this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add path_prefix parameter to cloud delivery option
2 participants