Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifications & Event Service] Adjust push notification registration event #852

Open
mplorentz opened this issue Jan 24, 2024 · 1 comment
Assignees
Labels
devx Work that will improve developer experience/velocity

Comments

@mplorentz
Copy link
Member

mplorentz commented Jan 24, 2024

In PushNotificationService.registerForNotifications(...) we send a kind 6666 to our push notification service. This kind was just a random one we picked, but now it is in use by NIP-90. We should change the kind number to 30078 which is "custom app data" as defined by NIP-78.

This isn't causing any bugs right now, but it will prevent confusion and potentially bugs in the future.

@mplorentz mplorentz added the devx Work that will improve developer experience/velocity label Jan 24, 2024
@setch-l setch-l changed the title Adjust push notification registration event [Notifications & Event Service] Adjust push notification registration event Jan 25, 2024
@mplorentz
Copy link
Member Author

To be clear: this needs to be changed on the server side and iOS app simultaneously. In fact we should have the server continue accepting kind 6666 for a week or so after deploying the iOS part of this so that our users have time to update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devx Work that will improve developer experience/velocity
Projects
Status: Backlog
Status: Delivery Backlog
Development

No branches or pull requests

2 participants