Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot localize report warnings #759

Open
mplorentz opened this issue Dec 21, 2023 · 3 comments
Open

Cannot localize report warnings #759

mplorentz opened this issue Dec 21, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@mplorentz
Copy link
Member

mplorentz commented Dec 21, 2023

Our Persian translator requested that we change the way we are constructing the message to explain that something was reported. These messages look like this: "This user has been reported by Matt and 1 other for profanity". In Persian the phrases need to be rearranged based on the pluralization (that's my understanding anyway). We have broken the sentence into multiple localized strings, so we need to combine them into one.

@mplorentz mplorentz added the bug Something isn't working label Dec 21, 2023
@mplorentz mplorentz self-assigned this Dec 21, 2023
@mplorentz
Copy link
Member Author

I fixed this in #742 and retroactively created this ticket. The english version of these strings should not have changed, but the Persian can now be localized.

@setch-l
Copy link

setch-l commented Jun 12, 2024

@mplorentz - Is this fixed for all languages or just Persian?

@mplorentz
Copy link
Member Author

@setch-l should be fixed in all languages. Meaning that they can now be properly translated in Crowdin. Except I just checked and they can't. It looks like Crowdin is only seeing our Localizable.strings file but not our other strings files like Moderation.strings, Reply.strings, etc. This looks like a configuration problem introduced after the work done for this ticket but I don't care if we use this ticket to track the fix or open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Archived in project
Development

No branches or pull requests

2 participants