Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[N things] Replace nprofile with Display Name if user has one #1312

Open
setch-l opened this issue Jul 16, 2024 · 3 comments
Open

[N things] Replace nprofile with Display Name if user has one #1312

setch-l opened this issue Jul 16, 2024 · 3 comments
Assignees

Comments

@setch-l
Copy link

setch-l commented Jul 16, 2024

Given that I am a user of Nos
When I am viewing an nprofile link in the app that is associated with a user who has a NIP05
Then I should see the Display Name as a link instead of a long string.

@joshuatbrown
Copy link
Contributor

joshuatbrown commented Aug 8, 2024

For example, this note should say Hey @Josh Brown!:

Here's what it currently looks like in the app:
Screenshot 2024-08-08 at 9 23 35 AM

We do render the NIP05 username when the nprofile is preceded by nostr:, as you can see in this note:

Screenshot 2024-08-08 at 9 28 27 AM

So basically, if we see a valid nprofile that's not preceded by nostr:, we should treat it the same way we do when it does have the nostr: prefix.

@setch-l
Copy link
Author

setch-l commented Aug 26, 2024

This work was done as part of something else.

@setch-l setch-l closed this as completed Aug 26, 2024
@joshuatbrown
Copy link
Contributor

@setch-l We still have some work to do on this. We've covered nostr:nprofile references but not nprofile references without the nostr: prefix.

@joshuatbrown joshuatbrown reopened this Aug 27, 2024
@setch-l setch-l changed the title [N things] Replace nprofile with NIP05 if user has one [N things] Replace nprofile with Display Name if user has one Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

3 participants