From 2e3e521ff41c3b23e43a0214fd0d7b33ede41056 Mon Sep 17 00:00:00 2001 From: Bryan Montz Date: Tue, 10 Sep 2024 07:55:13 -0500 Subject: [PATCH 1/2] localize follows notification #1446 --- Nos/Assets/Localization/Localizable.xcstrings | 45 +++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/Nos/Assets/Localization/Localizable.xcstrings b/Nos/Assets/Localization/Localizable.xcstrings index 717726263..c42898052 100644 --- a/Nos/Assets/Localization/Localizable.xcstrings +++ b/Nos/Assets/Localization/Localizable.xcstrings @@ -6646,6 +6646,17 @@ } } }, + "namedNewFollower" : { + "extractionState" : "manual", + "localizations" : { + "en" : { + "stringUnit" : { + "state" : "translated", + "value" : "%@ is a new follower!" + } + } + } + }, "nameLower" : { "extractionState" : "manual", "localizations" : { @@ -6752,6 +6763,17 @@ } } }, + "newFollower" : { + "extractionState" : "manual", + "localizations" : { + "en" : { + "stringUnit" : { + "state" : "translated", + "value" : "You have a new follower!" + } + } + } + }, "newNote" : { "extractionState" : "manual", "localizations" : { @@ -13428,6 +13450,29 @@ } } }, + "xNewFollowers" : { + "extractionState" : "manual", + "localizations" : { + "en" : { + "variations" : { + "plural" : { + "one" : { + "stringUnit" : { + "state" : "translated", + "value" : "You have %i new follower!" + } + }, + "other" : { + "stringUnit" : { + "state" : "translated", + "value" : "You have %i new followers!" + } + } + } + } + } + } + }, "yes" : { "extractionState" : "manual", "localizations" : { From 0a7574dedffb618ded636dbca0ff4121fd7d8b43 Mon Sep 17 00:00:00 2001 From: Bryan Montz Date: Wed, 11 Sep 2024 07:41:19 -0500 Subject: [PATCH 2/2] change plural number to string and update changelog --- CHANGELOG.md | 1 + Nos/Assets/Localization/Localizable.xcstrings | 18 +++--------------- 2 files changed, 4 insertions(+), 15 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a2e999f5d..47e5fd04d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Updated the copy on the 3 dots note menu. [#1028](https://github.com/planetary-social/nos/issues/1028) - Added functionality to share notes link through the 3 dots note menu. [#1272](https://github.com/planetary-social/nos/issues/1272) - Fixes and improvements related to Core Data usage. [#1443](https://github.com/planetary-social/nos/issues/1443) +- Localized follows notifications. [#1446](https://github.com/planetary-social/nos/issues/1446) ### Internal Changes - Use NIP-92 media metadata to display media in the proper orientation. Currently behind the “Enable new media display” feature flag. [#1172](https://github.com/planetary-social/nos/issues/1172) diff --git a/Nos/Assets/Localization/Localizable.xcstrings b/Nos/Assets/Localization/Localizable.xcstrings index ac5427eb2..20f4cd9c7 100644 --- a/Nos/Assets/Localization/Localizable.xcstrings +++ b/Nos/Assets/Localization/Localizable.xcstrings @@ -13465,21 +13465,9 @@ "extractionState" : "manual", "localizations" : { "en" : { - "variations" : { - "plural" : { - "one" : { - "stringUnit" : { - "state" : "translated", - "value" : "You have %i new follower!" - } - }, - "other" : { - "stringUnit" : { - "state" : "translated", - "value" : "You have %i new followers!" - } - } - } + "stringUnit" : { + "state" : "translated", + "value" : "You have %@ new followers!" } } }