Guarantee that rows are always returned in a consistent order.

Author: perlDreamer

CHANGES.txt

@@ -4,6 +4,9 @@ This file tracks the changes to Wing over time. Especially
 with respect to new features and compatibility changes.
 ==========================================================
 
+2024-08-01
+ * Guarantee that rows are always returned in a consistent order.
+
 2024-04-29
  * Modernize the install to latest Perl and fix a bunch of perl prereq problems.
 

lib/Wing/DB/ResultSet.pm

@@ -137,6 +137,7 @@ sub format_list {
     # ordering
     if (exists $options{order_by} && $options{order_by}) {
         my $order_by = $options{order_by};
+        my $has_id = 0;
         if (ref $order_by ne 'ARRAY') {
             $order_by = [$order_by];
         }
@@ -147,6 +148,10 @@ sub format_list {
                 next;
             }
 
+            if ($order_by->[$i] eq 'id' || $order_by->[$i] eq 'me.id' ) {
+                $has_id = 1;
+            }
+
             if ($order_by->[$i] !~ m/\./) {
                 $order_by->[$i] = 'me.'.$order_by->[$i];
             }
@@ -158,6 +163,9 @@ sub format_list {
                 }
             }
         }
+        if (! $has_id) {
+            push @{ $order_by }, 'me.id';
+        }
         $extra->{order_by} = $order_by;
     }
     if (exists $extra->{order_by} && $extra->{order_by} && exists $options{sort_order} && defined $options{sort_order} && $options{sort_order} eq 'desc') {