Skip to content

Handle failure to load json correctly in python2 #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joyzheng merged 2 commits into from
Apr 16, 2018
Merged

Handle failure to load json correctly in python2 #118

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd3de98
Fix failure to load json in python2
jzheng-plaid Apr 12, 2018
5b0c9d6
fix comment
jzheng-plaid Apr 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion plaid/requester.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@
ALLOWED_METHODS = {'post'}
DEFAULT_TIMEOUT = 600 # 10 minutes

try:
from json.decoder import JSONDecodeError
except ImportError:
# json parsing throws a ValueError in python2
JSONDecodeError = ValueError


def _requests_http_request(url, method, data, timeout=DEFAULT_TIMEOUT):
normalized_method = method.lower()
Expand All @@ -32,7 +38,7 @@ def http_request(url, method=None, data=None, timeout=DEFAULT_TIMEOUT):
response = _requests_http_request(url, method, data or {}, timeout)
try:
response_body = json.loads(response.text)
except json.JSONDecodeError:
except JSONDecodeError:
raise PlaidError.from_response({
'error_message': response.text,
'error_type': 'API_ERROR',
Expand Down