Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process not killed with a git bash on windows. #22

Open
jdflaugergues opened this issue Jul 5, 2018 · 1 comment
Open

process not killed with a git bash on windows. #22

jdflaugergues opened this issue Jul 5, 2018 · 1 comment

Comments

@jdflaugergues
Copy link

Hi,

I'm using an Angular wep application launched from a git bash terminal with ng serve.
When I want to exit the Angular web app with a Ctrl+C, the Angular @ngtools using tree-kill as a dependency send the following command treeKill(this._typeCheckerProcess.pid, 'SIGTERM') with the good pid. But tree-kill try to kill process by a taskkill command not recognized by git bash.
The issue is that it's the process.platform (here win32) which is identified and not the prompt.

Therefore, to resolve this issue, we have to identified git bash terminal and execute the following command exec('tskill' + pid) instead.

@billiegoose
Copy link
Collaborator

My git bash has no problem running taskkill... you should be able to run DOS commands like "dir" in git bash. Right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants