Skip to content

feat(devenv): detect skaffold.dev using skaffold.yaml file existence #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mxcl merged 1 commit into from
Oct 17, 2023
Merged

feat(devenv): detect skaffold.dev using skaffold.yaml file existence #810

mxcl merged 1 commit into from
Oct 17, 2023

Conversation

@vkumbhar94
Copy link
Contributor

@vkumbhar94 vkumbhar94 commented Oct 15, 2023

No description provided.

@coveralls
Copy link

coveralls commented Oct 15, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6523534689

  • 38 of 38 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 97.905%
Totals Coverage Status
Change from base Build 6517961201: 0.6%
Covered Lines: 1350
Relevant Lines: 1374
💛 - Coveralls

@vkumbhar94 vkumbhar94 changed the title feat(devenv): detect skaffold.dev using skaffold.yaml existence feat(devenv): detect skaffold.dev using skaffold.yaml file existence Oct 15, 2023
@vkumbhar94
Copy link
Contributor Author

vkumbhar94 commented Oct 15, 2023

@jhheider @mxcl Pls, have a look when you get some time. Thanks in adv :-)

jhheider
jhheider reviewed Oct 15, 2023
View reviewed changes
mxcl
mxcl approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@mxcl mxcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@mxcl mxcl merged commit c625b60 into pkgxdev:main Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxcl mxcl mxcl approved these changes

@jhheider jhheider jhheider left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vkumbhar94 @coveralls @mxcl @jhheider