Skip to content

Conversation

@mxcl
Copy link
Member

@mxcl mxcl commented Oct 8, 2023

Fixes #752; Refs #788

@mxcl mxcl marked this pull request as draft October 8, 2023 15:37
@coveralls
Copy link

coveralls commented Oct 8, 2023

Pull Request Test Coverage Report for Build 6653102864

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 96.892%

Totals Coverage Status
Change from base Build 6641472810: 0.007%
Covered Lines: 1386
Relevant Lines: 1423

💛 - Coveralls

@mxcl mxcl mentioned this pull request Oct 8, 2023
@mxcl mxcl force-pushed the uninstall branch 2 times, most recently from 982bccd to 0229a80 Compare October 17, 2023 14:14
@mxcl
Copy link
Member Author

mxcl commented Oct 17, 2023

I like the idea of the scripts themselves containing the uninstall logic since it means no database that may be deleted or corrupted separately.

However we will thus need to uninstall before updating anything that is already installed since we have no other way to return to a clean state first and the provides may vary between install invocations.

Basically needs more thought on how it should work

@mxcl mxcl force-pushed the main branch 3 times, most recently from 87d74ad to 1beb3a4 Compare October 17, 2023 16:08
@yoroshikun
Copy link
Contributor

To ship this earlier can we "whitelist" packages that have clear install path (simple binary) while others be blocked?
(eg. git, node)

@mxcl
Copy link
Member Author

mxcl commented Oct 23, 2023

I can prioritize finishing this. I didn’t think it was that important for 2 reasons:

  1. Uninstall is much less common an operation than install
  2. It’s pretty trivial to do by hand, you just delete the relevant files in one directory, it's not nearly the complexity of a normal package manager uninstall command that realisitically could not be done by hand in 99% of cases.

@mxcl mxcl marked this pull request as ready for review October 26, 2023 10:57
Fixes #752; Refs #788
@mxcl mxcl merged commit 96c5a10 into main Oct 26, 2023
@mxcl mxcl deleted the uninstall branch October 26, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tea uninstall fails

4 participants