Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add node 20 to test matrix #156

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

shadowspawn
Copy link
Collaborator

No description provided.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should add 22 also.

@@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [14, 16, 18]
node: [14, 16, 18, 20]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we set this up with an action that can keep it up to date automatically? i think pkgjs has one, but if not, i have ljharb/actions/node/matrix

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am aiming pretty low since there is a suggestion to archive repo: #149 (comment)

(Thanks for the review! I wasn't certain I would get one.)

@shadowspawn shadowspawn merged commit d2f6c87 into pkgjs:main Aug 19, 2024
7 checks passed
@shadowspawn shadowspawn deleted the add-node-20 branch August 19, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants