Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Clojurescript #3

Closed
lvh opened this issue May 22, 2015 · 7 comments
Closed

Support for Clojurescript #3

lvh opened this issue May 22, 2015 · 7 comments

Comments

@lvh
Copy link

lvh commented May 22, 2015

Clojurescript now has cljs.test. It'd be great if we can get the same awesome test output there :)

@lvh
Copy link
Author

lvh commented May 22, 2015

FWIW, reagent-project/reagent-template includes it but I can't tell if it actually works...

@arichiardi
Copy link
Collaborator

👍

@pjstadig
Copy link
Owner

I'd like to see this work, if it is possible. humane-test-output does Clojure specific not-so-nice things to clojure.test. If someone wants to take a crack at it and submit a PR, I'd gladly take a look at it.

@nenadalm
Copy link
Contributor

I started looking into it. It sort of works (there are just some excessive newlines...) And everything is duplicated into cljs (for now).

currently it is required to require some additional stuff in tests like do-report: 80f9137...nenadalm:clojurescript_support#diff-20936c87d473fea7e5d6351a664d091fR3

as I can't figure how to do that without these additional stuff here:
80f9137...nenadalm:clojurescript_support#diff-b85b3975b3dcdfd66cef6f3f0eb0a941R1

I am starting with clojure/clojurescript - so if anybody is willing to help...

I also included some files into test/fixtures/ which can be used to test if output stays the same after modifying code

$ lein test | diff test/fixtures/test_output -
$ lein cljsbuild test 2>&1 | diff test/fixtures/test_output_cljs -

@nenadalm
Copy link
Contributor

Now files are merged and excessive requires are removed.

Except I accidentaly created 2 files in namespace pjstadig.macro and when renaming the on from test/ it stops working.

@pjstadig
Copy link
Owner

@nenadalm would you mind creating a PR so we can start a conversation around your changes. Thanks for taking this on!

@nenadalm
Copy link
Contributor

done. np (it doesn't work anyway yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants