Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make report- public #28

Closed
arichiardi opened this issue Mar 13, 2018 · 2 comments
Closed

Make report- public #28

arichiardi opened this issue Mar 13, 2018 · 2 comments

Comments

@arichiardi
Copy link
Collaborator

Sometimes you need to compose humane-test-output with some other library (expound?) and I was wondering what would be the best approach for that.

It seems to me that the report- function could be exposed so that it can be used in custom defmethod test/report.

What do you think? Any other suggestion?

@pjstadig
Copy link
Owner

I'm not prepared to make report- public at this point. I think some things need to be cleaned up before I'm willing to let people depend on any implementation details. For now the workaround is to use the @#'report- hack to access a private var.

@arichiardi
Copy link
Collaborator Author

@pjstadig would you be open to reopen this issue 😄

I think in terms of composability to have a public function for reporting purposes is a good thing. The use case being combine your report with additional reports (like expound).

The workaround is not working in ClojureScript here:

Unable to resolve var: -report in this context at line 1 my/test_util.cljs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants