Merge branch 'feature/seeds' into python-slip39

Author: pjkundert

.gitignore

@@ -12,7 +12,7 @@ experiment/
 # Setuptools stuff
 build/
 dist/
-hdwallet.egg-info/
+hdwallet*.egg-info/
 
 # Python stuff
 __pycache__/

clients/brave_legacy.py

@@ -2,7 +2,7 @@
 
 from hdwallet import HDWallet
 from hdwallet.mnemonics import BIP39Mnemonic
-from hdwallet.seeds import BIP39Seed
+from hdwallet.seeds import BIP39Seed, SLIP39Seed
 from hdwallet.cryptocurrencies import Ethereum as Cryptocurrency
 from hdwallet.hds import BIP44HD
 from hdwallet.derivations import (
@@ -15,14 +15,14 @@
 MNEMONIC: str = "abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon " \
                 "abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon art"
 
-# Initialize Ethereum HDWallet
+# Initialize Ethereum HDWallet using BIP-39 Entropy as Seed
 hdwallet: HDWallet = HDWallet(
     cryptocurrency=Cryptocurrency,
     hd=BIP44HD,
     network=Cryptocurrency.NETWORKS.MAINNET,
     passphrase=None
 ).from_seed(   # Get Ethereum HDWallet from seed
-    seed=BIP39Seed(
+    seed=SLIP39Seed(
         seed=BIP39Mnemonic.decode(mnemonic=MNEMONIC)  # Use decoded mnemonic (entropy) directly as seed
     )
 ).from_derivation(  # Drive from BIP44 derivation
@@ -36,4 +36,28 @@
 
 # Same address of Brave crypto wallets extension
 # print(json.dumps(hdwallet.dump(exclude={"indexes"}), indent=4, ensure_ascii=False))
+print(f"Path: {hdwallet.path()}")
 print(f"Address: {hdwallet.address()}")
+
+assert hdwallet.address() == "0xACA6302EcBde40120cb8A08361D8BD461282Bd18"
+
+# Initialize Ethereum HDWallet using BIP-39 Seed (confirmed current Brave Wallet behavior)
+hdwallet: HDWallet = HDWallet(
+    cryptocurrency=Cryptocurrency,
+    hd=BIP44HD,
+    network=Cryptocurrency.NETWORKS.MAINNET,
+    passphrase=None
+).from_seed(   # Get Ethereum HDWallet from seed
+    seed=BIP39Seed.from_mnemonic(mnemonic=MNEMONIC)  # Use BIP-39 encoded mnemonic as seed
+).from_derivation(  # Drive from BIP44 derivation
+    derivation=BIP44Derivation(
+        coin_type=Cryptocurrency.COIN_TYPE,
+        account=0,
+        change=CHANGES.EXTERNAL_CHAIN,
+        address=0
+    )
+)
+
+# print(json.dumps(hdwallet.dump(exclude={"indexes"}), indent=4, ensure_ascii=False))
+print(f"Address: {hdwallet.address()}")
+assert hdwallet.address() == "0xF278cF59F82eDcf871d630F28EcC8056f25C1cdb"

clients/cardano/byron_icarus.py

@@ -38,7 +38,7 @@
 seed: str = CardanoSeed.from_mnemonic(
     mnemonic=bip39_mnemonic, cardano_type=Cardano.TYPES.BYRON_ICARUS
 )
-cardano_seed: CardanoSeed = CardanoSeed(seed=seed)
+cardano_seed: CardanoSeed = CardanoSeed(seed=seed, cardano_type=Cardano.TYPES.BYRON_ICARUS)
 
 # Update Byron-Icarus Cardano HD root keys from seed
 cardano_hd.from_seed(

clients/cardano/byron_ledger.py

@@ -38,7 +38,7 @@
 seed: str = CardanoSeed.from_mnemonic(
     mnemonic=bip39_mnemonic, cardano_type=Cardano.TYPES.BYRON_LEDGER
 )
-cardano_seed: CardanoSeed = CardanoSeed(seed=seed)
+cardano_seed: CardanoSeed = CardanoSeed(seed=seed, cardano_type=Cardano.TYPES.BYRON_LEDGER)
 
 # Update Byron-Ledger Cardano HD root keys from seed
 cardano_hd.from_seed(

clients/cardano/byron_legacy.py

@@ -38,7 +38,7 @@
 seed: str = CardanoSeed.from_mnemonic(
     mnemonic=bip39_mnemonic, cardano_type=Cardano.TYPES.BYRON_LEGACY
 )
-cardano_seed: CardanoSeed = CardanoSeed(seed=seed)
+cardano_seed: CardanoSeed = CardanoSeed(seed=seed, cardano_type=Cardano.TYPES.BYRON_LEGACY)
 
 # Update Byron-Legacy Cardano HD root keys from seed
 cardano_hd.from_seed(

clients/cardano/shelley_icarus.py

@@ -39,7 +39,7 @@
 seed: str = CardanoSeed.from_mnemonic(
     mnemonic=bip39_mnemonic, cardano_type=Cardano.TYPES.SHELLEY_ICARUS
 )
-cardano_seed: CardanoSeed = CardanoSeed(seed=seed)
+cardano_seed: CardanoSeed = CardanoSeed(seed=seed, cardano_type=Cardano.TYPES.SHELLEY_ICARUS)
 
 # Update Shelley-Icarus Cardano HD root keys from seed
 cardano_hd.from_seed(

clients/cardano/shelley_ledger.py

@@ -39,7 +39,7 @@
 seed: str = CardanoSeed.from_mnemonic(
     mnemonic=bip39_mnemonic, cardano_type=Cardano.TYPES.SHELLEY_LEDGER
 )
-cardano_seed: CardanoSeed = CardanoSeed(seed=seed)
+cardano_seed: CardanoSeed = CardanoSeed(seed=seed, cardano_type=Cardano.TYPES.SHELLEY_LEDGER)
 
 # Update Shelley-Ledger Cardano HD root keys from seed
 cardano_hd.from_seed(

examples/hdwallet/algorand/from_seed.py

@@ -14,7 +14,7 @@
     hd=AlgorandHD
 ).from_seed(
     seed=AlgorandSeed(
-        seed="fca87b68fdffa968895901c894f678f6"
+        seed="a27436e742dafe27428b84925d4be6a1c40856d14dc73d54431a94bd6b95264b"
     )
 ).from_derivation(
     derivation=CustomDerivation(

examples/hdwallet/cardano/from_entropy.py

@@ -24,7 +24,7 @@
 ).from_entropy(
     entropy=BIP39Entropy(
         entropy=BIP39Entropy.generate(
-            strength=BIP39_ENTROPY_STRENGTHS.TWO_HUNDRED_TWENTY_FOUR
+            strength=BIP39_ENTROPY_STRENGTHS.ONE_HUNDRED_TWENTY_EIGHT
         )
     )
 ).from_derivation(

examples/hdwallet/cardano/from_seed.py

@@ -20,7 +20,8 @@
     passphrase="talonlab"
 ).from_seed(
     seed=CardanoSeed(
-        seed="fca87b68fdffa968895901c894f678f6"
+        seed="fca87b68fdffa968895901c894f678f6",
+        cardano_type=Cryptocurrency.TYPES.SHELLEY_ICARUS,
     )
 ).from_derivation(
     derivation=CIP1852Derivation(