Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #117 - Add command to open or create tag page #118

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mvaaltola
Copy link

@mvaaltola mvaaltola commented Oct 16, 2023

Add command to open a tag page or create one if it doesn't exist. Also handles internal and external links so it can be used to replace the default "Follow link under cursor" command (Alt+Enter by default).

Closes #117.

@pjeby
Copy link
Owner

pjeby commented Oct 17, 2023

I think what I actually want to do is provide settings in the plugin for whether you want to have tag clicks (and Follow link under cursor) open tag pages or search, and then patch Editor.prototype.triggerClickableToken() to behave accordingly. In this way, no new commands or keybindings are required, and I want to provide settings for this to address other outstanding issues regarding what happens when you click tags in other contexts.

That's going to require some careful consideration, though, as it's not just a matter of one toggle, as I want to have options for how it will respond to other kinds of clicks, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: navigate to tag page on Alt+Enter
2 participants