Upgrade from go 1.19 to 1.20 #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesMBartlett
previously approved these changes
Feb 2, 2023
|
@pixie-labs-buildbot , test this please |
vihangm
force-pushed
the
go_1_20
branch
3 times, most recently
from
c704dd0 to
be44c32
Compare
Signed-off-by: Vihang Mehta <vihang@pixielabs.ai>
Signed-off-by: Vihang Mehta <vihang@pixielabs.ai>
Signed-off-by: Vihang Mehta <vihang@pixielabs.ai>
#ci:bpf-build Signed-off-by: Vihang Mehta <vihang@pixielabs.ai>
Signed-off-by: Vihang Mehta <vihang@pixielabs.ai>
zasgar
approved these changes
Feb 3, 2023
| "tRzQMDQiYCOhgHOvgSeycJPJHYNufNjJhhjUVRuSqfgqVMkPYVkURUpiFvIZRgBmyArKCtzkjkZIvaBjMkXVbWGv" | ||
| "bqzgexyALBsdjSGpngCwFkDifIBuufFMoWdiTskZoQJMqrTICTojIYxyeSxZyfroRODMbNDRZnPNRWCJPMHDtJmH" | ||
| "AYORsUfUMApsVgzHblmYYtEjVgwfFbbGGcnqbaEREunUZjQXmZOtaRLUtmYgmSVYB... [TRUNCATED]")); | ||
| // TODO(oazizi): random data isn't consistent across go versions. Switch to non-random data or |
There was a problem hiding this comment.
@vihangm, can you file an issue so that we don't forget to fix it?
RagalahariP
pushed a commit
to RagalahariP/pixie
that referenced
this pull request
Feb 15, 2023
Summary: Upgrade from go version 1.19 to 1.20 Type of change: /kind cleanup Test Plan: `bazel test //...` Signed-off-by: Vihang Mehta <vihang@pixielabs.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Upgrade from go version 1.19 to 1.20
Type of change: /kind cleanup
Test Plan:
bazel test //...