[build] Disable tcmalloc for GCC build #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vihangm
approved these changes
Jun 8, 2023
Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
JamesMBartlett
force-pushed
the
fix_coverage_build
branch
from
3c122e9 to
483fdb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: tcmalloc was causing strange linker errors with CGO builds when linker with gold. Not really sure what's going on, since lld can link these things without issue. We should probably investigate this more, but for now this is a stop-gap that will unblock the coverage build. Since we don't ever deploy GCC built binaries, removing tcmalloc shouldn't matter too much for now.
Type of change: /kind cleanup
Test Plan: Ran
bazel build //src/vizier/services/query_broker:query_broker --config=gccwithout error, this was failing on main before this PR.