Skip to content

Commit fc1a4fa

Browse files
authored
Update Nginx Ingress to use ImplementationSpecific pathType to avoid admission controller issues (#2215)
Summary: Update Nginx Ingress to use `ImplementationSpecific` pathType to avoid admission controller issues Nginx Ingress [v1.8.0](https://github.com/kubernetes/ingress-nginx/blob/311a2082c5622c7bdaff24273110e6f2a0f3b5da/changelog/controller-1.8.0.md?plain=1#L16) introduced a `strict-validate-path-type` setting that defaults to true. This causes the existing pathType used by Pixie's manifest to be blocked by the Nginx Ingress admission controller. Updating this value to `ImplementationSpecific` side steps this validation, so it can be created successfully. > For improving security, our 1.8.0 release includes a [new, optional validation ](https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/configmap/#strict-validate-path-type)that limits the characters accepted on ".spec paths.path" when pathType=Exact or pathType=Prefix, to alphanumeric characters only. Relevant Issues: #2214 Type of change: /kind bugfix Test Plan: Deployed to a cluster using Nginx Ingress Changelog Message: Fixed an issue where Nginx Ingress resource creation would be blocked by admission controller (on Nginx Ingress v1.8.0 and later) Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
1 parent fcf2516 commit fc1a4fa

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

k8s/cloud/overlays/exposed_services_nginx/cloud_ingress_grpcs.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,21 +20,21 @@ spec:
2020
http:
2121
paths:
2222
- path: /px.services.(.*)
23-
pathType: Prefix
23+
pathType: ImplementationSpecific
2424
backend:
2525
service:
2626
name: vzconn-service
2727
port:
2828
number: 51600
2929
- path: /px.cloudapi.(.*)
30-
pathType: Prefix
30+
pathType: ImplementationSpecific
3131
backend:
3232
service:
3333
name: api-service
3434
port:
3535
number: 51200
3636
- path: /px.api.(.*)
37-
pathType: Prefix
37+
pathType: ImplementationSpecific
3838
backend:
3939
service:
4040
name: cloud-proxy-service
@@ -44,21 +44,21 @@ spec:
4444
http:
4545
paths:
4646
- path: /px.services.(.*)
47-
pathType: Prefix
47+
pathType: ImplementationSpecific
4848
backend:
4949
service:
5050
name: vzconn-service
5151
port:
5252
number: 51600
5353
- path: /px.cloudapi.(.*)
54-
pathType: Prefix
54+
pathType: ImplementationSpecific
5555
backend:
5656
service:
5757
name: api-service
5858
port:
5959
number: 51200
6060
- path: /px.api.(.*)
61-
pathType: Prefix
61+
pathType: ImplementationSpecific
6262
backend:
6363
service:
6464
name: cloud-proxy-service

0 commit comments

Comments
 (0)