Skip to content

Commit 970a54a

Browse files
authored
Clear trace response instead of metric response in OTelExportSinkNode::ConsumeSpans (#1910)
Summary: Addresses a couple of small-ish bugs - `ConsumeSpans` is mistakenly clearing the `metrics_response_` (which is used in `ConsumeMetrics`) instead of the `trace_response_`. - There is a duplicate return statement in `OTelModule::Init`. Type of change: /kind bug Test Plan: CI, skaffold-ed standalone pem and ran OTel export scripts Signed-off-by: Benjamin Kilimnik <bkilimnik@pixielabs.ai>
1 parent 1d41f9b commit 970a54a

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

src/carnot/exec/otel_export_sink_node.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@ Status OTelExportSinkNode::ConsumeSpans(ExecState* exec_state, const RowBatch& r
340340
}
341341
context.set_compression_algorithm(GRPC_COMPRESS_GZIP);
342342

343-
metrics_response_.Clear();
343+
trace_response_.Clear();
344344
opentelemetry::proto::collector::trace::v1::ExportTraceServiceRequest request;
345345

346346
for (int64_t row_idx = 0; row_idx < rb.ColumnAt(0)->length(); ++row_idx) {

src/carnot/planner/objects/otel.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,6 @@ Status OTelModule::Init(CompilerState* compiler_state, IR* ir) {
338338

339339
AddMethod(kEndpointOpID, endpoint_fn);
340340
PX_RETURN_IF_ERROR(endpoint_fn->SetDocString(kEndpointOpDocstring));
341-
return Status::OK();
342341

343342
return Status::OK();
344343
}

0 commit comments

Comments
 (0)