Update comment, revert condition change for inferring connection info to find local_addr if accept/connect not traced

benkilimnik · benkilimnik · commit 58564696f13d · 2024-01-23T23:23:24.000Z
Signed-off-by: Benjamin Kilimnik &lt;bkilimnik@pixielabs.ai&gt;
diff --git a/src/stirling/source_connectors/socket_tracer/conn_tracker.cc b/src/stirling/source_connectors/socket_tracer/conn_tracker.cc
@@ -796,7 +796,7 @@ void ConnTracker::IterationPreTick(
   }
 
   // If remote_addr is missing, it means the connect/accept was not traced.
-  // Attempt to infer the connection information, to populate remote_addr.
+  // Attempt to infer the connection information, to populate remote_addr and local_addr.
   if (open_info_.remote_addr.family == SockAddrFamily::kUnspecified && socket_info_mgr != nullptr) {
     InferConnInfo(proc_parser, socket_info_mgr);
 

Original file line number	Diff line number	Diff line change
`@@ -796,7 +796,7 @@ void ConnTracker::IterationPreTick(`
`796`	`796`	`}`
`797`	`797`
`798`	`798`	`// If remote_addr is missing, it means the connect/accept was not traced.`
`799`		`- // Attempt to infer the connection information, to populate remote_addr.`
	`799`	`+ // Attempt to infer the connection information, to populate remote_addr and local_addr.`
`800`	`800`	`if (open_info_.remote_addr.family == SockAddrFamily::kUnspecified && socket_info_mgr != nullptr) {`
`801`	`801`	`InferConnInfo(proc_parser, socket_info_mgr);`
`802`	`802`