Rename new scriptmgr RPC to CheckScriptExists

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>

Author: ddelnano

src/cloud/api/ptproxy/vizier_pt_proxy.go

@@ -46,7 +46,7 @@ type vzmgrClient interface {
 }
 
 type scriptmgrClient interface {
-	GetScriptByHash(ctx context.Context, req *scriptmgrpb.GetScriptByHashReq, opts ...grpc.CallOption) (*scriptmgrpb.GetScriptByHashResp, error)
+	CheckScriptExists(ctx context.Context, req *scriptmgrpb.CheckScriptExistsReq, opts ...grpc.CallOption) (*scriptmgrpb.CheckScriptExistsResp, error)
 }
 
 // VizierPassThroughProxy implements the VizierAPI and allows proxying the data to the actual
@@ -73,7 +73,7 @@ func (v *VizierPassThroughProxy) isScriptModified(ctx context.Context, script st
 	hash := sha256.New()
 	hash.Write([]byte(script))
 	hashStr := hex.EncodeToString(hash.Sum(nil))
-	req := &scriptmgrpb.GetScriptByHashReq{Sha256Hash: hashStr}
+	req := &scriptmgrpb.CheckScriptExistsReq{Sha256Hash: hashStr}
 
 	serviceAuthToken, err := getServiceCredentials(viper.GetString("jwt_signing_key"))
 	ctx = metadata.AppendToOutgoingContext(ctx, "authorization",
@@ -83,7 +83,7 @@ func (v *VizierPassThroughProxy) isScriptModified(ctx context.Context, script st
 		return false, err
 	}
 
-	resp, err := v.sm.GetScriptByHash(ctx, req)
+	resp, err := v.sm.CheckScriptExists(ctx, req)
 
 	if err != nil {
 		return false, err

src/cloud/api/ptproxy/vizier_pt_proxy_test.go

@@ -856,14 +856,14 @@ func TestVizierPassThroughProxy_DebugPods(t *testing.T) {
 
 type fakeScriptMgr struct{}
 
-func (s *fakeScriptMgr) GetScriptByHash(ctx context.Context, req *scriptmgrpb.GetScriptByHashReq, opts ...grpc.CallOption) (*scriptmgrpb.GetScriptByHashResp, error) {
+func (s *fakeScriptMgr) CheckScriptExists(ctx context.Context, req *scriptmgrpb.CheckScriptExistsReq, opts ...grpc.CallOption) (*scriptmgrpb.CheckScriptExistsResp, error) {
 	hash := "488f131003f415a61090901c544e0ace731e8a85b12ce0aea770273d656f08e0" // sha256 of "liveview1 pxl"
 
 	scripts := map[string]bool{
 		hash: true,
 	}
 	_, ok := scripts[req.Sha256Hash]
-	return &scriptmgrpb.GetScriptByHashResp{
+	return &scriptmgrpb.CheckScriptExistsResp{
 		Exists: ok,
 	}, nil
 }

src/cloud/scriptmgr/controllers/server.go

@@ -259,11 +259,11 @@ func (s *Server) GetScriptContents(ctx context.Context, req *scriptmgrpb.GetScri
 	}, nil
 }
 
-// GetScriptByHash returns if a script with the given hash exists.
-func (s *Server) GetScriptByHash(ctx context.Context, req *scriptmgrpb.GetScriptByHashReq) (*scriptmgrpb.GetScriptByHashResp, error) {
+// CheckScriptExists returns if a script with the given hash exists.
+func (s *Server) CheckScriptExists(ctx context.Context, req *scriptmgrpb.CheckScriptExistsReq) (*scriptmgrpb.CheckScriptExistsResp, error) {
 	hash := req.Sha256Hash
 	_, ok := s.store.ScriptHashes[hash]
-	return &scriptmgrpb.GetScriptByHashResp{
+	return &scriptmgrpb.CheckScriptExistsResp{
 		Exists: ok,
 	}, nil
 }

src/cloud/scriptmgr/controllers/server_test.go

@@ -324,7 +324,7 @@ func TestScriptMgr_GetScriptContents(t *testing.T) {
 	}
 }
 
-func TestScriptMgr_GetScriptByHash(t *testing.T) {
+func TestScriptMgr_CheckScriptExists(t *testing.T) {
 	testCases := []struct {
 		name       string
 		scriptHash string
@@ -350,13 +350,13 @@ func TestScriptMgr_GetScriptByHash(t *testing.T) {
 			c := mustSetupFakeBucket(t, testBundle)
 			s := controllers.NewServer(bundleBucket, bundlePath, c)
 			ctx := context.Background()
-			req := &scriptmgrpb.GetScriptByHashReq{
+			req := &scriptmgrpb.CheckScriptExistsReq{
 				Sha256Hash: tc.scriptHash,
 			}
-			expectedResp := &scriptmgrpb.GetScriptByHashResp{
+			expectedResp := &scriptmgrpb.CheckScriptExistsResp{
 				Exists: tc.exists,
 			}
-			resp, err := s.GetScriptByHash(ctx, req)
+			resp, err := s.CheckScriptExists(ctx, req)
 			if tc.expectErr {
 				require.NotNil(t, err)
 			} else {