Skip to content

Commit 49e06d1

Browse files
committed
Name new env var with correct prefix to work for cloud services, frontend and proxy service
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
1 parent 92cfa6e commit 49e06d1

File tree

8 files changed

+9
-9
lines changed

8 files changed

+9
-9
lines changed

k8s/cloud/base/proxy_nginx_config.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ data:
135135
set_by_lua_block $segment_cli_write_key { return os.getenv("PL_SEGMENT_CLI_WRITE_KEY") }
136136
set_by_lua_block $script_bundle_urls { return os.getenv("SCRIPT_BUNDLE_URLS") }
137137
set_by_lua_block $script_bundle_dev { return os.getenv("SCRIPT_BUNDLE_DEV") }
138-
set_by_lua_block $script_modification_disabled { return os.getenv("SCRIPT_MODIFICATION_DISABLED") }
138+
set_by_lua_block $script_modification_disabled { return os.getenv("PL_SCRIPT_MODIFICATION_DISABLED") }
139139
set_by_lua_block $analytics_enabled { return os.getenv("ANALYTICS_ENABLED") }
140140
set_by_lua_block $announcement_enabled { return os.getenv("ANNOUNCEMENT_ENABLED") }
141141
set_by_lua_block $announce_widget_url { return os.getenv("ANNOUNCE_WIDGET_URL") }
@@ -172,7 +172,7 @@ data:
172172
env PL_KRATOS_SERVICE;
173173
env SCRIPT_BUNDLE_URLS;
174174
env SCRIPT_BUNDLE_DEV;
175-
env SCRIPT_MODIFICATION_DISABLED;
175+
env PL_SCRIPT_MODIFICATION_DISABLED;
176176
env ANALYTICS_ENABLED;
177177
env ANNOUNCEMENT_ENABLED;
178178
env ANNOUNCE_WIDGET_URL;

k8s/cloud/base/script_bundles_config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ data:
99
"https://artifacts.px.dev/pxl_scripts/bundle.json"
1010
]
1111
SCRIPT_BUNDLE_DEV: "false"
12-
SCRIPT_MODIFICATION_DISABLED: "false"
12+
PL_SCRIPT_MODIFICATION_DISABLED: "false"

k8s/cloud/dev/script_bundles_config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ data:
1010
"https://artifacts.px.dev/pxl_scripts/bundle.json"
1111
]
1212
SCRIPT_BUNDLE_DEV: "false"
13-
SCRIPT_MODIFICATION_DISABLED: "false"
13+
PL_SCRIPT_MODIFICATION_DISABLED: "false"

k8s/cloud/prod/script_bundles_config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ data:
1010
"https://artifacts.px.dev/pxl_scripts/bundle.json"
1111
]
1212
SCRIPT_BUNDLE_DEV: "false"
13-
SCRIPT_MODIFICATION_DISABLED: "false"
13+
PL_SCRIPT_MODIFICATION_DISABLED: "false"

k8s/cloud/public/base/script_bundles_config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ data:
99
"https://artifacts.px.dev/pxl_scripts/bundle.json"
1010
]
1111
SCRIPT_BUNDLE_DEV: "false"
12-
SCRIPT_MODIFICATION_DISABLED: "false"
12+
PL_SCRIPT_MODIFICATION_DISABLED: "false"

k8s/cloud/staging/script_bundles_config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ data:
1010
"https://artifacts.px.dev/pxl_scripts/bundle.json"
1111
]
1212
SCRIPT_BUNDLE_DEV: "false"
13-
SCRIPT_MODIFICATION_DISABLED: "false"
13+
PL_SCRIPT_MODIFICATION_DISABLED: "false"

k8s/cloud/testing/script_bundles_config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ data:
1010
"https://artifacts.px.dev/pxl_scripts/bundle.json"
1111
]
1212
SCRIPT_BUNDLE_DEV: "false"
13-
SCRIPT_MODIFICATION_DISABLED: "false"
13+
PL_SCRIPT_MODIFICATION_DISABLED: "false"

src/ui/webpack.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ module.exports = (env, argv) => {
302302
__CONFIG_LD_CLIENT_ID__: JSON.stringify(yamls.ld.data.PL_LD_CLIENT_ID),
303303
__CONFIG_SCRIPT_BUNDLE_URLS__: JSON.stringify(yamls.scriptBundle.data.SCRIPT_BUNDLE_URLS),
304304
__CONFIG_SCRIPT_BUNDLE_DEV__: JSON.parse(yamls.scriptBundle.data.SCRIPT_BUNDLE_DEV),
305-
__CONFIG_SCRIPT_MODIFICATION_DISABLED__: JSON.parse(yamls.scriptBundle.data.SCRIPT_MODIFICATION_DISABLED),
305+
__CONFIG_SCRIPT_MODIFICATION_DISABLED__: JSON.parse(yamls.scriptBundle.data.PL_SCRIPT_MODIFICATION_DISABLED),
306306
__SEGMENT_ANALYTICS_JS_DOMAIN__: `"segment.${yamls.domain.data.PL_DOMAIN_NAME}"`,
307307
}),
308308
);

0 commit comments

Comments
 (0)