Skip to content

Commit

Permalink
feat(notifications): alert notifications badges no longer need modifi…
Browse files Browse the repository at this point in the history
…er classes

[#97701618]
  • Loading branch information
Geoff Pleiss authored and Geoff Pleiss committed Jul 1, 2015
1 parent 1b94fdd commit f4b963c
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/pivotal-ui-react/notifications/notifications.js
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,10 @@ var Notifications = React.createClass({
var AlertNotifications = React.createClass({
render() {
var {children} = this.props;
var badge = children ? <Icon name="exclamation-triangle" className="dropdown-notifications-alert h4 type-warn-2"></Icon> : null;
var badge = children ? <Icon name="exclamation-triangle" className="dropdown-notifications-alert"></Icon> : null;
var dropdownTitle = (
<div className="dropdown-notifications-title">
<i className="fa fa-bell type-neutral-6 fa-h2 mvn"></i>
<i className="fa fa-bell"></i>
{badge}
</div>
);
Expand Down
3 changes: 2 additions & 1 deletion src/pivotal-ui/components/dropdowns/dropdowns.scss
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ This is a notification dropdown with alerts.
<button data-toggle="dropdown" class="dropdown-toggle btn btn-link" type="button">
<div class="dropdown-notifications-title">
<i class="fa fa-bell"></i>
<i class="fa fa-exclamation-triangle dropdown-notifications-alert type-warn-2"></i>
<i class="fa fa-exclamation-triangle dropdown-notifications-alert"></i>
</div>
</button>
<ul class="dropdown-menu" role="menu">
Expand Down Expand Up @@ -364,6 +364,7 @@ This is a notification dropdown with alerts.
position: absolute;
top: -6px;
right: 6px;
color: $notifications-alert-default-color;
}

.dropdown-notifications-list {
Expand Down
1 change: 1 addition & 0 deletions src/pivotal-ui/components/pui-variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,7 @@ $notifications-bell-default-size: $font-size-h2;
$notifications-bell-default-color: $neutral-6;
$notifications-badge-default-bg: $brand-3;
$notifications-badge-font-wieght: 900;
$notifications-alert-default-color: $warn-2;


// COMPONENT VARIABLES
Expand Down

0 comments on commit f4b963c

Please sign in to comment.