Skip to content

Commit

Permalink
feat(google-maps): Removes Maps dependency on id for height styling
Browse files Browse the repository at this point in the history
[Finishes #94686466]

BREAKING CHANGE: (css class) Google maps now need the `.labs-map` class
to get styles.
  • Loading branch information
Kenny Wang and Tyler Phelan authored and Geoff Pleiss and Kenny Wang committed Jul 14, 2015
1 parent 038048e commit d24e699
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/pivotal-ui/components/google-maps/google-maps.scss
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Full width map with marker at Pivotal Labs SF location, and an optional informat
</div>
</div>
<div class='pane pane-map'>
<div id='labs-map'></div>
<div class='labs-map' id='my-google-map'></div>
</div>
</div>
```
Expand All @@ -53,7 +53,8 @@ var maps = (function() {
var mapOptions = {
placeId: "ChIJ9w1pfYiAhYAR45k8AD-TjhA",
center: new google.maps.LatLng(37.781787,-122.403911),
mapElementId: 'labs-map',
mapElementClass: 'labs-map',
mapElementId: 'my-google-map',
zoom: 18
};
Expand Down Expand Up @@ -111,6 +112,6 @@ google.maps.event.addDomListener(window, 'load', maps.initialize);
}
}

#labs-map {
.labs-map {
height: 100%;
}

0 comments on commit d24e699

Please sign in to comment.