fix(OverlayTrigger): Do not increase delay of hiding/showing if asked to

show or hide multiple times

[fixes #131134283]

Signed-off-by: Yucheng Tu <ytu@pivotal.io>

library/spec/pivotal-ui-react/overlay-trigger/overlay-trigger_spec.js

@@ -161,6 +161,17 @@ describe('OverlayTrigger', function() {
         jasmine.clock().tick(3000);
         expect(subject.setState).not.toHaveBeenCalled();
       });
+
+      it('does not delay an action if it happens repeatedly', () => {
+        subject::setProps({delay: 3000});
+        subject.show();
+        expect('.tooltip-text').not.toExist();
+        jasmine.clock().tick(1000);
+        subject.show();
+        expect('.tooltip-text').not.toExist();
+        jasmine.clock().tick(2000);
+        expect('.tooltip-text').toExist();
+      });
     });
   });
 

library/src/pivotal-ui-react/overlay-trigger/overlay-trigger.js

@@ -91,12 +91,24 @@ class OverlayTrigger extends mixin(React.Component).with(Scrim) {
   };
 
   setDisplay = (display) => {
-    clearTimeout(privates.get(this).timeout);
-    if(display === this.state.display) return;
+    const oldTimeout = privates.get(this).timeout;
+
+    if(display === this.state.display) {
+      clearTimeout(oldTimeout);
+      privates.set(this, {timeout: null});
+      return;
+    }
+
     const delay = this.getDelay(display);
+
+    if(oldTimeout && delay) return;
+
     let timeout;
     if(delay) {
-      timeout = setTimeout(() => {this.setState({display})}, delay);
+      timeout = setTimeout(() => {
+        privates.set(this, {timeout: null});
+        this.setState({display})
+      }, delay);
     } else {
       this.setState({display});
     }