Skip to content

Commit

Permalink
fix(alerts): Add color back to notification alert icon
Browse files Browse the repository at this point in the history
Also remove the HTML example for the now-deprecated notification markup
Also fix the spelling of a PUI SCSS variable
[Fixes #99271410]
  • Loading branch information
matt-royal authored and Caroline Taymor and Matt Royal committed Jul 20, 2015
1 parent 73bdc8d commit 70ab958
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 50 deletions.
54 changes: 5 additions & 49 deletions src/pivotal-ui/components/dropdowns/dropdowns.scss
Original file line number Diff line number Diff line change
Expand Up @@ -339,54 +339,6 @@ This is a notification dropdown with alerts.
</ul>
</div>
```
<div class="alert alert-danger mbxl">
<h5 class="em-high mtn">
Deprecation warning
</h5>
<p>
The example below shows the old markup for notifications alerts. It will
not be supported in the next major release. Please change your notifications
to match the examples above.
</p>
</div>
```html_example
<div class="dropdown btn-group">
<a data-toggle="dropdown" class="dropdown-toggle btn btn-link" type="button">
<i class="fa fa-bell type-neutral-6 mvn h2"></i>
<span class="dropdown-notifications-badge">2</span>
</a>
<ul class="dropdown-menu dropdown-notifications-list" role="menu">
<li role="presentation">
<a role="menuitem" href="https://twitter.com/fat">
<div class="media man pan">
<div class="media-left media-middle">
<h3 class="label label-primary mrm">New</h3>
</div>
<div class="media-body media-middle">
<h5 class="media-heading mbn type-dark-1">Notification</h5>
<p class="type-sm type-neutral-5 mvn">News for you</p>
</div>
</div>
</a>
</li>
<li role="presentation">
<a role="menuitem" href="https://twitter.com/fat">
<div class="media man pan">
<div class="media-left media-middle">
<h3 class="label label-primary mrm">New</h3>
</div>
<div class="media-body media-middle">
<h5 class="media-heading mbn type-dark-1">Pivotal-CF</h5>
<p class="type-sm type-neutral-5 mvn">1 New File Available</p>
</div>
</div>
</a>
</li>
</ul>
</div>
```
*/

.dropdown-notifications-none {
Expand Down Expand Up @@ -420,12 +372,16 @@ This is a notification dropdown with alerts.
background-color: $notifications-badge-default-bg;
color: white;
text-align: center;
font-weight: $notifications-badge-font-wieght;
font-weight: $notifications-badge-font-weight;
padding: 0.25em;
line-height: 0.75em;
min-width: 1.25em;
}

.dropdown-notifications-alert {
color: $notifications-alert-default-color;
}

.dropdown-notifications-alert, .dropdown-notifications-badge {
position: absolute;
font-size: 0.75em;
Expand Down
2 changes: 1 addition & 1 deletion src/pivotal-ui/components/pui-variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ $dropdown-caret-color: #000 !default;
$notifications-bell-default-size: $font-size-h2;
$notifications-bell-default-color: $neutral-6;
$notifications-badge-default-bg: $brand-3;
$notifications-badge-font-wieght: 900;
$notifications-badge-font-weight: 900;
$notifications-alert-default-color: $warn-2;


Expand Down

0 comments on commit 70ab958

Please sign in to comment.